From f34ca07e88cbed5952785049c42f7b39b560e04b Mon Sep 17 00:00:00 2001 From: ApsisRS contributors Date: Sat, 26 Sep 2026 23:39:08 +0800 Subject: [PATCH] ci: check and lint with all features The facade crate enables nothing by default, so cargo check and cargo clippy without --all-features skipped almost all of its code and every example. A deliberate mistake placed in feature gated facade code was invisible to the old commands and caught by the new ones. --- .github/workflows/ci.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e7c0beb..797cfe4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,11 +18,13 @@ jobs: - name: Format run: cargo fmt --all --check - name: Check - run: cargo check --workspace --all-targets + # --all-features matters: the facade crate enables nothing by default, + # so without it almost all of its code, and every example, is skipped. + run: cargo check --workspace --all-targets --all-features - name: Clippy - run: cargo clippy --workspace --all-targets -- -D warnings + run: cargo clippy --workspace --all-targets --all-features -- -D warnings - name: Test - run: cargo test --workspace + run: cargo test --workspace --all-features - name: Integration checks # The cross-layer checks are examples rather than tests, because they # are also meant to be read and run by hand. `cargo test` does not run